-Zharden-sls flag (target modifier) added to enable mitigation against straight line speculation (SLS) #136597
+245
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
…t straight line speculation (SLS)
14 tasks
56 tasks
|
Some changes occurred in compiler/rustc_codegen_gcc |
|
First commit adds retpoline feature, but PR descriptions says about sls. |
Yes, first commit is in another PR #135927. |
|
Marking this as blocked on #135927 |
Dylan-DPC
added
S-blocked
|
I filed an MCP for this flag: rust-lang/compiler-team#869 |
|
☔ The latest upstream changes (presumably #141232) made this pull request unmergeable. Please resolve the merge conflicts. |
workingjubilee
requested changes
Jun 14, 2025
Comment on lines
+9
to
+14
| #![feature(no_core, lang_items)] | ||
| #![no_std] | ||
| #![no_core] | ||
|
|
||
| #[lang = "sized"] | ||
| pub trait Sized {} |
There was a problem hiding this comment.
Use add-core-stubs, don't handwrite the minicore.
workingjubilee
requested changes
Jun 14, 2025
Comment on lines
+1
to
+6
| warning: target feature `retpoline-external-thunk` cannot be enabled with `-Ctarget-feature`: use `x86-retpoline` target modifier flag instead | ||
| | | ||
| = note: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! | ||
| = note: for more information, see issue #116344 <https://github.com/rust-lang/rust/issues/116344> | ||
|
|
||
| warning: 1 warning emitted |
There was a problem hiding this comment.
Why is this possible at all?
| //@ compile-flags: --target=x86_64-unknown-linux-gnu --crate-type=lib | ||
| //@ needs-llvm-components: x86 | ||
| //@ [by_flag]compile-flags: -Zharden-sls=all | ||
| //@ [by_feature]compile-flags: -Ctarget-feature=+harden-sls-ijmp,+harden-sls-ret |
There was a problem hiding this comment.
These should not be set by -Ctarget-feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag (target modifier) to mitigate against straight line speculation (SLS).
-Zharden-sls=[none|all|return|indirect-jmp].The flag enables the related features:
+harden-sls-ijmp,+harden-sls-ret.The flag is tracked as a target modifier to be equal between linked crates.
Tracking issue: #116851